feat: easy localstack integration #635
Conversation
|
Hi @aleslash. Thanks for your PR. I'm waiting for a aws-controllers-k8s member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ack-prow
bot
added
the
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: a-hilaly, aleslash The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/ok-to-test |
ack-prow
bot
added
ok-to-test
| {{- if .Values.aws.identity_endpoint_url }} | ||
| - --aws-identity-endpoint-url | ||
| - "$(AWS_IDENTITY_ENDPOINT_URL)" | ||
| {{- end }} | ||
| {{- if .Values.aws.allow_unsafe_aws_endpoint_urls }} | ||
| - --allow-unsafe-aws-endpoint-urls | ||
| {{- end }} |
There was a problem hiding this comment.
Thank you for your PR @aleslash.
These need to be a template of a template like:
{{ "{{- if .Values.log.enable_development_logging }}" }}
- --enable-development-logging
{{ "{{- end }}" }}
can you please address this?
|
@aleslash: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
2 participants
Issue #, if available:
Description of changes:
Made possible to use ack helm chart with localstack for easy local development.
In order to run ack with localstack and kind you need to configure ack controller to have the identity_endpoint_url set to sts in localstack and enable the allow_unsafe_aws_endpoint_urls.
Without this PR it is impossible to use the original chart.
The chart now has two new optional parameters that enable this integration locally in kind environment.
The deployment manifest now also have this optional parameters.
So, when applying the new helm chart, you can use this:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.